Dan Kenigsberg has posted comments on this change. Change subject: More logging for missing nics. ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41782/4/vdsm/network/models.py File vdsm/network/models.py: Line 87: _netinfo = netinfo.NetInfo() Line 88: if name not in _netinfo.nics: Line 89: raise ConfigNetworkError( Line 90: ne.ERR_BAD_NIC, 'unknown nic: %s. Known nics: %s' % ( Line 91: name, _netinfo.nics.keys())) 10:25:03 name, _netinfo.nics.keys())) 10:25:03 AttributeError: 'list' object has no attribute 'keys' Line 92: Line 93: if _netinfo.ifaceUsers(name): Line 94: mtu = max(mtu, netinfo.getMtu(name)) Line 95: -- To view, visit https://gerrit.ovirt.org/41782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib80dbad981e748a53cc71fc77cb20aadd6677513 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
