Ido Barkan has posted comments on this change. Change subject: tests: print all routes if _get_gateway couldn't report a gateway ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42280/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1677: self.assertEqual(status, SUCCESS, msg) Line 1678: self.assertNetworkExists(NETWORK_NAME) Line 1679: test_net = self.vdsm_net.netinfo.networks[NETWORK_NAME] Line 1680: # _get_gateway doesn't report a gateway if there are multiple Line 1681: print(json.dumps(_get_routes(), indent=4)) can you also dump netdict? Line 1682: if 4 in families: Line 1683: self.assertEqual(IP_ADDRESS, test_net['addr']) Line 1684: self.assertEqual(IP_MASK, test_net['netmask']) Line 1685: self.assertIn(IP_ADDRESS_AND_CIDR, test_net['ipv4addrs']) -- To view, visit https://gerrit.ovirt.org/42280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09ce006f2644e24674d3445a287008d5e1660a5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
