Allon Mureinik has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build ......................................................................
Patch Set 6: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41858/6/vdsm.spec.in File vdsm.spec.in: Line 293: Requires: glusterfs-cli Line 294: Requires: glusterfs-api Line 295: Requires: glusterfs-fuse Line 296: Requires: glusterfs-geo-replication Line 297: Requires: glusterfs-rdma these packages won't be shipped in the regular rhel channels (or centos builds, for that matter). I'm fine with always shipping vdsm-gluster and allowing the end user to decide whether to install it or not, but I'm not fine with breaking VDSM's installation over gluster if the user doesn't have it installed. These requirements should be limited to vdsm-gluster - see below. Line 298: Line 299: Requires: psmisc >= 22.6-15 Line 300: Requires: bridge-utils Line 301: Requires: sos Line 714: Requires: %{name} = %{version}-%{release} Line 715: Requires: glusterfs-server Line 716: Requires: python-magic Line 717: %if 0%{?rhel} > 6 || 0%{?fedora} Line 718: Requires: python-blivet The requirements should be moved here. Line 719: %endif Line 720: Line 721: %description gluster Line 722: Gluster plugin enables VDSM to serve Gluster functionalities. -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
