Nir Soffer has posted comments on this change.

Change subject: WIP: Remove Vdsm's dependency on gluster-server package.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41568/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 419:     def set_rp_filter_loose(self, dev):
Line 420:         sysctl.set_rp_filter_loose(dev)
Line 421: 
Line 422:     @logDecorator
Line 423:     def volumeInfo(self, remoteServer, volumeName=None):
This is gluster specific verb, should be named glusterVolumeInfo.

This should replace the glusterVolumeInfo registered by the gluster when 
gluster is enabled.
Line 424:         return glusterUtils.volumeInfo(remoteServer, volumeName)
Line 425: 
Line 426:     @logDecorator
Line 427:     def set_rp_filter_strict(self, dev):


-- 
To view, visit https://gerrit.ovirt.org/41568
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to