Yeela Kaplan has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms ......................................................................
Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/36701/18/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 133: self._destServer = jsonrpcvdscli.connect(client) Line 134: self.log.debug('Initiating connection with destination') Line 135: self._destServer.ping() Line 136: Line 137: except Exception: > Never use this catching-all "except" clause. You would not want to use xmrp Done Line 138: if config.getboolean('vars', 'ssl'): Line 139: self._destServer = vdscli.connect( Line 140: hostPort, Line 141: useSSL=True, -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches