Francesco Romani has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks ......................................................................
Patch Set 3: (1 comment) missing unit test. Works in the positive flow - tried running a patched VDSM https://gerrit.ovirt.org/#/c/41657/3/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 245: except Exception: Line 246: # we want to make sure to have VM UUID logged Line 247: self._log.exception("while dispatching %s to VM '%s'", Line 248: self._create, vm_id) Line 249: maybe keep the else: block and move the try/except below inside it? I'm not a fan that style, I like the current approach. Line 250: try: Line 251: self._executor.dispatch(op, self._timeout) Line 252: except executor.TooManyTasks: Line 253: skipped.append(vm_id) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
