Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: raise and except only specific exceptions ......................................................................
migration: raise and except only specific exceptions Right now on migration over JsonRpc we swallow any RuntimeError, when actually we might need to fail the migration. To avoid this we will do except clause only for very specific JsonRpcErrors. Change-Id: I4cf662d99493921910821f263b6a5a4542d1604f Signed-off-by: Yeela Kaplan <[email protected]> Reviewed-on: https://gerrit.ovirt.org/42385 Reviewed-by: Yaniv Bronhaim <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/jsonrpcvdscli.py M lib/yajsonrpc/__init__.py M vdsm/clientIF.py M vdsm/virt/migration.py 4 files changed, 23 insertions(+), 6 deletions(-) Approvals: Yeela Kaplan: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cf662d99493921910821f263b6a5a4542d1604f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
