Nir Soffer has posted comments on this change. Change subject: protocoldetecor: SSLError handled not correctly ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/42206/5//COMMIT_MSG Commit Message: Line 7: protocoldetecor: SSLError handled not correctly Line 8: Line 9: Whenever there was ssl issue during protocol detection the code entered Line 10: infinite loop because we haven't remove fd from pending_connections. Line 11: It is fixed by caching SSLError reading data and clean up fd correctly. > is this the reason why it is not master branch as well? please rephrase if In master this code does not exist, it was replaced by new code using the reactor. This bug may or may not be in master, need testing. Line 12: Line 13: Line 14: Change-Id: I8ea5c305b19c0a7421ea74e069c3ad02d9ffd141 Line 15: Signed-off-by: pkliczewski <[email protected]> -- To view, visit https://gerrit.ovirt.org/42206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ea5c305b19c0a7421ea74e069c3ad02d9ffd141 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
