Dan Kenigsberg has posted comments on this change. Change subject: Removing support in sysv and upstart ......................................................................
Patch Set 8: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/40726/8//COMMIT_MSG Commit Message: Line 9: rhel older than 6.7 -> el6, which has been dropped from the master branch. Line 11: rhel 7 el7 https://gerrit.ovirt.org/#/c/40726/8/vdsm.spec.in File vdsm.spec.in: Line 643 Line 644 Line 645 Line 646 Line 647 We still need them! Line 744 Line 745 Line 746 Line 747 Line 748 dropping systemctl enable is a noble cause, but it is unrelated to sropping of sysv and upstart - please put it in a separate patch. Line 1090: #compat Line 1091: %{_datadir}/%{vdsm_name}/config.py* Line 1092: %{_datadir}/%{vdsm_name}/netinfo.py* Line 1093: %endif Line 1094: %exclude %{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py* it would be much better to drop this file completely (in a separate patch, if you prefer) Line 1095: %{python_sitelib}/%{vdsm_name}/tool/configfile.py* Line 1096: %{python_sitelib}/%{vdsm_name}/tool/dummybr.py* Line 1097: %{python_sitelib}/%{vdsm_name}/tool/dump_bonding_defaults.py* Line 1098: %{python_sitelib}/%{vdsm_name}/tool/nwfilter.py* -- To view, visit https://gerrit.ovirt.org/40726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
