Bala.FA has posted comments on this change. Change subject: Provides partial device details on any disk failure ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/42435/1/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 130: ignoredDisks You should have global ignoredDisks and use whenever needed. You should also have an option to re-probe ignoredDisks. Line 139: _ignoreFaultyDevAndRetry This leads to never-ending loop. You should fix without recursion. -- To view, visit https://gerrit.ovirt.org/42435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd92b49df10e35365868d243423e01cb3d84832b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
