Xu He Jie has posted comments on this change.
Change subject: change startup process for vdsm and supervdsm
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File vdsm/supervdsmServer.py
Line 354: log.debug("Creating remote object manager")
Line 355: manager.register('instance', callable=_SuperVdsm)
Line 356:
Line 357: server = manager.get_server()
Line 358: servThread = threading.Thread(target=server.serve_forever)
Why run server as another thread?
Line 359: servThread.setDaemon(True)
Line 360: servThread.start()
Line 361:
Line 362: chown(ADDRESS, VDSM_USER, VDSM_GROUP)
--
To view, visit http://gerrit.ovirt.org/4145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
