Dan Kenigsberg has posted comments on this change. Change subject: hooks: Open vSwitch configurator ......................................................................
Patch Set 41: (2 comments) https://gerrit.ovirt.org/#/c/40312/41/vdsm.spec.in File vdsm.spec.in: Line 607: openvswitch we should find (or found..) a yum repo hosting this. Or at lease point users to http://cbs.centos.org/kojifiles/packages/openvswitch/2.3.1/2.el7/x86_64/openvswitch-2.3.1-2.el7.x86_64.rpm https://gerrit.ovirt.org/#/c/40312/41/vdsm_hooks/ovs/ovs_before_network_setup.py File vdsm_hooks/ovs/ovs_before_network_setup.py: Line 25: - print created command in a nicer way - single line for one command, Line 26: `comment adding|editing|removing network xxxx` Line 27: - improve performance, iterations, data structures, joining lists etc Line 28: - use some sets to not iterate running config over and over Line 29: - create libvirt network? ! this is required so that we can use the network for a VM's display network. Line 30: - more caps and stats from ovs-ofctl show Line 31: - if ovs command fail, dont end with unexpected exception but smt more verbose Line 32: - not able to rewrite non ovs network with ovs (?) - list all limitations Line 33: in README -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
