Dan Kenigsberg has posted comments on this change. Change subject: network: allow custom bondOption ......................................................................
Patch Set 7: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/40882/7/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2367: Line 2368: @cleanupNet Line 2369: @ValidateRunningAsRoot Line 2370: def test_setupNetworks_bond_with_custom_option(self): Line 2371: with dummyIf(1) as nics: OVS loves two ifaces Line 2372: status, msg = self.vdsm_net.setupNetworks( Line 2373: {}, Line 2374: {BONDING_NAME: {'nics': nics, Line 2375: 'options': 'custom=foo mode=balance-rr'}}, Line 2368: @cleanupNet Line 2369: @ValidateRunningAsRoot Line 2370: def test_setupNetworks_bond_with_custom_option(self): Line 2371: with dummyIf(1) as nics: Line 2372: status, msg = self.vdsm_net.setupNetworks( needs a rebase for vdsm_net removal Line 2373: {}, Line 2374: {BONDING_NAME: {'nics': nics, Line 2375: 'options': 'custom=foo mode=balance-rr'}}, Line 2376: NOCHK) -- To view, visit https://gerrit.ovirt.org/40882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
