Dan Kenigsberg has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le ......................................................................
Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42471/3/vdsm.spec.in File vdsm.spec.in: Line 156: Requires: %{name}-xmlrpc = %{version}-%{release} Line 157: Requires: %{name}-jsonrpc = %{version}-%{release} Line 158: Requires: safelease >= 1.0-5 Line 159: Line 160: %if %{_arch} == ppc64le I believe this is evaluated only once, during build time. I am not aware of a way of adding arch-specific dependecies to a noarch package. What we did before is the horribly despicable hack of placing the dependency in safelease. Line 161: %{warn:Ceph is not avilable on ppc64le} Line 162: %else Line 163: Requires: ceph-common Line 164: %endif -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sagi Shnaidman <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
