Mark Wu has posted comments on this change. Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: Itamar, 1. My understanding is that the bootstrap detection you mentioned is a fix for fake_kvm_support. Without that fix, engine would refuse to add the virtual vdsm host even fake_kvm_support is enabled. And the purpose of this patch is enable the option fake_kvm_support on non VT host automatically. That could be helpful for test. 2. /proc/cpuinfo always report the cpu flag (vmx) if the cpu has the capability even if virtualization support is disabled in bios. So I think it's fine to determine if the host has virt support by the cpu flag. -- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
