Nir Soffer has posted comments on this change. Change subject: spec: Move vdsm package contents to vdsm-deamon ......................................................................
Patch Set 1: (1 comment) Yaniv, sorry for the terse commit messages, these patches were done in very quickly. we tried in the past to solve this by adding a separate package for arch dependencies, but this was rejected by the fedora reviewers - see https://bugzilla.redhat.com/show_bug.cgi?id=1133479#c7 This series implement the fedora reviewer recommendation - see https://bugzilla.redhat.com/show_bug.cgi?id=1133479#c13 Why it is better: 1. This is the blessed way 2. This is simpler 3. We can move safelease back, and avoid unneeded and painfull dependencies on external package https://gerrit.ovirt.org/#/c/42491/1/vdsm.spec.in File vdsm.spec.in: Line 304: Line 305: Conflicts: vdsm-hook-sriov Line 306: Line 307: %description Line 308: Meta-package depending on various vdsm sub packages. > this meta-package shouldn't require all the above ^ but the vdsm-daemon afa I'm trying to simplify, having one level of dependencies is easier to understand and maintain. Line 309: Line 310: %package daemon Line 311: Summary: VDSM daemon Line 312: BuildArch: noarch -- To view, visit https://gerrit.ovirt.org/42491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b0b0e7461f9ac10a189dd8ca6715d02183ad21 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nelly Credi <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
