Federico Simoncelli has posted comments on this change.

Change subject: resize-lun: Add resizePV verb
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/40467/5/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 714: 
Line 715:     def resizePV(self, guid):
Line 716:         with self._extendlock:
Line 717:             lvm.resizePV(self.sdUUID, guid)
Line 718:             self.updateMapping()
Is this to update only "pecount" or is there something else as well?
Line 719:             newsize = self.metaSize(self.sdUUID)
Line 720:             lvm.extendLV(self.sdUUID, sd.METADATA, newsize)
Line 721: 
Line 722:     _lvTagMetaSlotLock = threading.Lock()


-- 
To view, visit https://gerrit.ovirt.org/40467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38f9e603a66adbe2655173b8043766f6c04a7913
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to