Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Resize devices in connectStorageServer ......................................................................
Patch Set 16: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40864/16/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2396: def __prefetchDomains(self, domType, conObj): Line 2397: uuidPatern = "????????-????-????-????-????????????" Line 2398: Line 2399: if domType in (sd.FCP_DOMAIN, sd.ISCSI_DOMAIN): Line 2400: sdCache.refreshStorage() I think it would have been clearer in connectStorageServer with a proper comment. Line 2401: uuids = tuple(blockSD.getStorageDomainsList()) Line 2402: elif domType is sd.NFS_DOMAIN: Line 2403: lPath = conObj._mountCon._getLocalPath() Line 2404: self.log.debug("nfs local path: %s", lPath) -- To view, visit https://gerrit.ovirt.org/40864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia574a59047d2fb5dd3ac7360c2c3a9dde05237ef Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
