Dan Kenigsberg has posted comments on this change. Change subject: net: introducing KernelConfig ......................................................................
Patch Set 15: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41973/15/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 354: def _normalize_bonding_opts(self, config_copy): Line 355: for bond, bond_attr in config_copy.bonds.iteritems(): Line 356: # TODO: globalize default bond options from Bond in models.py Line 357: normalized_opts = self._parse_bond_options( Line 358: bond_attr.get('options', 'mode=802.3ad miimon=150')) I'm fine with keeping these defaults for now, but if it makes life simpler, we can drop them, as only ancient engines (<=3.0) sends no options and expects mode=4. Line 359: bond_attr['options'] = self._netinfo.bondOptsForIfcfg( Line 360: normalized_opts) Line 361: Line 362: def _normalize_bonding_nics(self, config_copy): -- To view, visit https://gerrit.ovirt.org/41973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
