Dan Kenigsberg has submitted this change and it was merged. Change subject: net: reset bonding options to defaults. ......................................................................
net: reset bonding options to defaults. When an existing bond is edited, replacing bonding options in the ifcfg file and ifdown+ifup is not enough. This is because ifcfg script will only set the options that are indicated. This is a bug since what is persisted is not what is eventually configured on the edited bond. This is solved by resetting the non default options back before ifup. testSetupNetworksResizeBond was changed to point at the bug and prove it is solved. Change-Id: Ibe720674e63119e954265735e9f5ccb994c3531a Signed-off-by: Ido Barkan <[email protected]> Reviewed-on: https://gerrit.ovirt.org/42115 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Jenkins CI --- M tests/functional/networkTests.py M vdsm/network/configurators/ifcfg.py 2 files changed, 83 insertions(+), 5 deletions(-) Approvals: Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe720674e63119e954265735e9f5ccb994c3531a Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
