Saggi Mizrahi has posted comments on this change. Change subject: Bz#839919 remoteFileHandler.py: Add storage into python path ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/remoteFileHandler.py Line 46: from vdsm.betterPopen import BetterPopen Line 47: from vdsm import constants Line 48: # We add the parent directory so that imports that import the storage Line 49: # package would work even though CWD is inside the storage package. Line 50: sys.path.append(os.path.dirname(os.path.abspath(__file__))) Isn't this the current directory? The original code adds the parent directory Line 51: Line 52: Line 53: class Timeout(RuntimeError): Line 54: pass -- To view, visit http://gerrit.ovirt.org/6354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id23c3d0be6eb2e2212172613ea8f3b0c58edce06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
