Dan Kenigsberg has posted comments on this change. Change subject: vmstats: TypeError is unlikely with modern libvirt ......................................................................
Patch Set 7: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/40917/7//COMMIT_MSG Commit Message: Line 10: use of virTypedParameter, which the Python Line 11: bindings make safe to transform in the proper Line 12: native types. Line 13: Line 14: Thus, a TypeError is highly unlikely those days. I believe that TypeError was introduced not against crazy values in libvirt response, but against more mundane last_sample == None cases, which are properly tested nowadays. Still, the bottom line applies. Line 15: Line 16: Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
