Nir Soffer has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg ......................................................................
Patch Set 11: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41568/11/vdsm.spec.in File vdsm.spec.in: Line 279: %endif # rhel Line 280: Line 281: # GlusterFS client-side RPMs needed for Gluster SD Line 282: Requires: glusterfs-cli >= %{gluster_version} Line 283: Requires: glusterfs-fuse >= %{gluster_version} Darshan, These dependencies are not enough - we depend now on supervdsmServer.glusterVolumeInfo() for mounting a gluster domain (see https://gerrit.ovirt.org/40665 and https://gerrit.ovirt.org/41931). In older version of this patch (https://gerrit.ovirt.org/#/c/41568/7), you moved the required code info vdsm, which made it possible to use glusterfs storage domain without installing vdsm-gluster. For that version, we do need the glusterfs-cli and glusterfs-fuse packages as vdsm requirement. However since you reverted these changes in version 8 of this patch, we are depending again on vdsm-gluster, so these dependencies belong in vdsm-gluster package, and not in vdsm. In the current version, this patch does not solve anything. You removed the server dependencies, but we cannot use the client packages because the code to use them is included in a package which still required the server packages :-) Line 284: Line 285: Requires: psmisc >= 22.6-15 Line 286: Requires: bridge-utils Line 287: Requires: sos -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
