Dan Kenigsberg has posted comments on this change.

Change subject: configNetwork: Ignore libvirt exception for network removing
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 259:                 except libvirt.libvirtError, e:
Line 260:                     if e.get_error_code() == 
libvirt.VIR_ERR_NO_NETWORK:
Line 261:                         pass
Line 262:             else:
Line 263:                 self._createNetwork(content)
I think that the same goes here, to created - but existing - networks.
Line 264:             logging.info('Restored %s', network)
Line 265: 
Line 266:     def _backup(self, filename):
Line 267:         self._atomicBackup(filename)


--
To view, visit http://gerrit.ovirt.org/7062
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb2044ddfa2cd4e194ad2315eceb9a815aa164fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to