Yaniv Bronhaim has posted comments on this change. Change subject: WIP: packaging: updating for VDSM 4.17 on Debian jessie ......................................................................
Patch Set 19: (7 comments) https://gerrit.ovirt.org/#/c/37737/19/debian/control File debian/control: Line 1: Source: vdsm Line 2: Section: admin Line 3: Priority: extra Line 4: Maintainer: Simone Tiraboschi <[email protected]> I'd keep past maintainers' names for tracking Line 5: Build-Depends: debhelper (>= 8.0.0), Line 6: autoconf, Line 7: automake, Line 8: dosfstools, Line 27: python-rpm, Line 28: python-selinux, Line 29: sudo (>= 1.7.3), Line 30: python-simplejson (>= 2.0.9), Line 31: python-ioprocess (>= 0.14) we introduced also - safelease >= 1.0-5 Line 32: Standards-Version: 3.9.4 Line 33: Homepage: http://www.ovirt.org/wiki/Vdsm Line 34: Vcs-Git: git://gerrit.ovirt.org/vdsm Line 35: Vcs-Browser: http://gerrit.ovirt.org/gitweb?p=vdsm.git Line 358: Architecture: all Line 359: Depends: ${shlibs:Depends}, ${misc:Depends}, python (>=2.7.3), vdsm (>= ${source:Version}) Line 360: Description: To configure spice options for vm Line 361: This vdsm hook can be used to configure some of Line 362: the spice optimization attributes and values. keep the vdsm-hooks above, and then the vdsm-* packages. Line 363: Line 364: Package: vdsm-infra Line 365: Architecture: all Line 366: Depends: ${shlibs:Depends}, ${misc:Depends}, python (>=2.7.3) https://gerrit.ovirt.org/#/c/37737/19/debian/vdsm-jsonrpc-java-javadoc.install File debian/vdsm-jsonrpc-java-javadoc.install: Line 1: usr/share/javadoc/vdsm-jsonrpc-java why do we need this ? Line 2: usr/share/javadoc/vdsm-jsonrpc-java/allclasses-frame.html Line 3: usr/share/javadoc/vdsm-jsonrpc-java/allclasses-noframe.html Line 4: usr/share/javadoc/vdsm-jsonrpc-java/constant-values.html Line 5: usr/share/javadoc/vdsm-jsonrpc-java/deprecated-list.html https://gerrit.ovirt.org/#/c/37737/19/debian/vdsm-jsonrpc-java.install File debian/vdsm-jsonrpc-java.install: Line 1: usr/share/java/vdsm-jsonrpc-java we don't install it as part of vdsm Line 2: usr/share/java/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client.jar Line 3: usr/share/maven-effective-poms/JPP.vdsm-jsonrpc-java-vdsm-jsonrpc-java-client.pom Line 4: usr/share/maven-fragments/vdsm-jsonrpc-java.xml Line 5: usr/share/maven-poms/JPP.vdsm-jsonrpc-java-root.pom https://gerrit.ovirt.org/#/c/37737/19/debian/vdsm-python.install File debian/vdsm-python.install: Line 1 does vdsm.conf removal intentional ? https://gerrit.ovirt.org/#/c/37737/19/debian/vdsm.prerm File debian/vdsm.prerm: Line 36: /etc/default/sanlock Line 37: Line 38: # Restoring backuped logrotate.d/libvirtd Line 39: sed -i -e 's/# VDSM backup//' /etc/logrotate.d/libvirtd Line 40: saslpasswd2 -p -a libvirt -d vdsm@ovirt this is not required any more ^ all of it is being handled by vdsm-tool configure call. we removed it from the spec as well. systemctl calls will also remove with https://gerrit.ovirt.org/42605 Line 41: ;; Line 42: Line 43: upgrade) Line 44: ;; -- To view, visit https://gerrit.ovirt.org/37737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04be8619306e387f8fd528e2bf072c37e7ea8483 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
