Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Delete Drive.diskReplicate before saving config ......................................................................
vm: Delete Drive.diskReplicate before saving config When drive replication is finished, either by pivoting to the destination volume or keeping the source volume, Drive.diskReplicate must be deleted, to ensure that high watermark monitoring is correct. The current code could fail to delete diskReplicate if the disk was not found in Vm.conf, or saving state failed. This could lead to incorrect extend requests for non-existent volume. Change-Id: I3112f94a4877e28057497749938aa8c3d7771d30 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40220 Reviewed-by: Francesco Romani <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3112f94a4877e28057497749938aa8c3d7771d30 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
