Dan Kenigsberg has submitted this change and it was merged. Change subject: net: introducing KernelConfig ......................................................................
net: introducing KernelConfig KernelConfig can be created from a NetInfo object. It reflects the network kernel state and exposes an API similar to RunningConfig. At this stage, It can compare itself to a RunninConfig instance in order to be tested properly and prove it is 'correct'. Later, it should be able to tell which networks/bonds it obtained from the kernel are different from a given PersistentConfig's networks/bodns. This is useful at boot time in order to allow skipping restoring already configured networks. Since VDSM network api has language differences from netinfo module and also has many default parameters, KernelConfig tries to do 2 things: 1. It tries to be expilict as possible (no defaults) 2. It knows how to 'normalize' a running/persistent config so it would also be explicit. Note the custom properties are never included in KernelConfig, as they only serve as hints to Vdsm and its hooks. Therefore, tests which set custom properties would certainly get into RunningConfig!=KernelConfig. These tests pass test_kernel_config=False so as not to fail. Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Signed-off-by: Ido Barkan <ibar...@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203422 Reviewed-on: https://gerrit.ovirt.org/41973 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/netconfpersistence.py M lib/vdsm/netinfo.py M tests/functional/networkTests.py 3 files changed, 258 insertions(+), 5 deletions(-) Approvals: Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
