Francesco Romani has posted comments on this change. Change subject: Fixed scratchpad hook's image permissions and virtio device name ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42573/2/vdsm_hooks/scratchpad/before_vm_start.py File vdsm_hooks/scratchpad/before_vm_start.py: Line 38: if retcode != 0: Line 39: sys.stderr.write('scratchpad: error running command %s, err = %s\n' % Line 40: (' '.join(command), err)) Line 41: sys.exit(2) Line 42: os.chmod(path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRP | stat.S_IWGRP) > Unfortunately we cannot control permissions by umask and this is qemu-img p OK, thanks for investigation. Fair enough, let's stick with chmod. Should be good enough. Line 43: Line 44: Line 45: def indexToDiskName(i): Line 46: s = '' -- To view, visit https://gerrit.ovirt.org/42573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Marchukov <amarc...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Anton Marchukov <amarc...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Wenyi Gao <we...@linux.vnet.ibm.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
