Ido Barkan has posted comments on this change. Change subject: net: SetupNetworks small cleanups. ......................................................................
Patch Set 22: (3 comments) https://gerrit.ovirt.org/#/c/42022/22//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-06-05 00:05:44 +0300 Line 4: Commit: Ido Barkan <[email protected]> Line 5: CommitDate: 2015-06-24 16:47:18 +0300 Line 6: Line 7: net: SetupNetworks small cleanups. > why '.'? i'm sorry about typo bullying Done Line 8: Line 9: Extracted the logic that alters network arguments for _addNetwork Line 10: to functions, did some internal renaming and few small cleanups. Line 11: https://gerrit.ovirt.org/#/c/42022/22/vdsm/network/api.py File vdsm/network/api.py: Line 713: _netinfo.updateDevices() # Things like a bond mtu can change Line 714: Line 715: Line 716: def _update_add_network_arguments(attrs, bondings, _netinfo): Line 717: """update a specific network attributes with relevant bonding/ nic > Update Done Line 718: info.""" Line 719: args = dict(attrs) Line 720: if 'bonding' in args: Line 721: args.update(_build_bond_options( Line 734: 2. Bonding already exists on the host. This is indicated by just naming Line 735: the bonding name in the network attributes dictionary. In this case Line 736: VDSM tries to get bonding options and nics from the kernel. User might Line 737: add extra configuration to change an existing bond. Line 738: Eitherway, bonding name, options and nics are places in the network > placed? Done Line 739: attributes before given to the configurator. Line 740: """ Line 741: bond = {} Line 742: non_existing_bond = bondings.get(bond_name) -- To view, visit https://gerrit.ovirt.org/42022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
