Dan Kenigsberg has posted comments on this change. Change subject: caps: remove CPU map parsing ......................................................................
Patch Set 4: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/42757/4//COMMIT_MSG Commit Message: Line 6: Line 7: caps: remove CPU map parsing Line 8: Line 9: Because nowadays the cluster is an atomic migration unit and same cpu Line 10: vendors across cluster is enforced, it doesn't make sense to limit the Please explain how this is enforced. I have not noticed that we report the vendor to Engine. Please elaborate how Bug 737104 - 3.1 - disallow cross-vendor VM emulation is not re-introduced by your patch. Line 11: possible baselines processors for the host. Line 12: Line 13: Change-Id: Ic5dc42d8bbf3c5a48b1bc4fb3dade59c94b24e7f https://gerrit.ovirt.org/#/c/42757/4/vdsm/caps.py File vdsm/caps.py: Line 411: try: Line 412: return c.compareCPU(xml, 0) in (libvirt.VIR_CPU_COMPARE_SUPERSET, Line 413: libvirt.VIR_CPU_COMPARE_IDENTICAL) Line 414: except libvirt.libvirtError as e: Line 415: # hack around libvirt BZ#795836 > since you're fixing this function, please remove this hack as well preferably in a different patch. Line 416: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 417: return False Line 418: raise Line 419: -- To view, visit https://gerrit.ovirt.org/42757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5dc42d8bbf3c5a48b1bc4fb3dade59c94b24e7f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
