Francesco Romani has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages ......................................................................
Patch Set 1: Code-Review+1 (2 comments) seems a good solution, I can't think of any major drawback atm. I can't help but wonder why it rarely happens (if ever) outside CI. https://gerrit.ovirt.org/#/c/42915/1//COMMIT_MSG Commit Message: Line 8: Line 9: get_request method is used in BaseServer#_handle_request_noblock and it Line 10: is explicitly stated in docstring that the method should not block. Line 11: Line 12: We can't use xmlrpc build-in timeout handling because we detect a typo: built-in Line 13: protocol and pass socket for processing. Line 14: Line 15: Line 16: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a https://gerrit.ovirt.org/#/c/42915/1/lib/vdsm/xmlrpc.py File lib/vdsm/xmlrpc.py: Line 127: def add(self, connected_socket, socket_address): Line 128: self.queue.put((connected_socket, socket_address)) Line 129: Line 130: def get_request(self): Line 131: return self.queue.get(block=True, timeout=3) this magic number deserves a comment Line 132: Line 133: def server_close(self): Line 134: self.queue.put((None, None)) Line 135: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches