Dan Kenigsberg has submitted this change and it was merged.

Change subject: ceph: Undefine existing secret if usage changed
......................................................................


ceph: Undefine existing secret if usage changed

When re-defining a secret, libvirt does not allow to change the usage
id.  We know that we will have to change the usage id in the next
version, when moving secrets from Cinder provider to the storage domain
using the Cinder provider.

So now lookup existing secrets and undefine secrets with different
usage id before defining new secret.

Change-Id: Ib258f0be1cdd4f2672b9adaad35da13d48279ce6
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/40967
Reviewed-by: Francesco Romani <[email protected]>
Reviewed-by: Daniel Erez <[email protected]>
Reviewed-by: Adam Litke <[email protected]>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M tests/vmSecretTests.py
M vdsm/virt/secret.py
2 files changed, 22 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40967
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib258f0be1cdd4f2672b9adaad35da13d48279ce6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to