Adam Litke has posted comments on this change. Change subject: Live merge: Update base size after live merge ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/42921/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4928: # we are removing, the size of the top volume might be larger than the Line 4929: # size of the base volume. In that case libvirt has enlarged the base Line 4930: # volume automatically as part of the blockCommit operation. Update Line 4931: # our metadata to reflect this change. Line 4932: topVolUUID = self.job['topVolume'] > Lets add also baseVolUUID temporary, which will make _setVolumeSize() littl Done Line 4933: info = self.vm._getVolumeInfo(self.drive.domainID, self.drive.poolID, Line 4934: self.drive.imageID, topVolUUID) Line 4935: self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID, Line 4936: self.drive.imageID, self.job['baseVolume'], Line 4929: # size of the base volume. In that case libvirt has enlarged the base Line 4930: # volume automatically as part of the blockCommit operation. Update Line 4931: # our metadata to reflect this change. Line 4932: topVolUUID = self.job['topVolume'] Line 4933: info = self.vm._getVolumeInfo(self.drive.domainID, self.drive.poolID, > Lets call it topVolInfo, to make it more clear that we copy the capacity fr Done Line 4934: self.drive.imageID, topVolUUID) Line 4935: self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID, Line 4936: self.drive.imageID, self.job['baseVolume'], Line 4937: info['capacity']) Line 4996: else: Line 4997: self.vm.log.error("Bad volume chain found for drive %s. " Line 4998: "Previous chain: %s, Expected chain: %s, " Line 4999: "Actual chain: %s", alias, origVols, Line 5000: expectedVols, curVols) > This fix is not related to this patch - right? Can you separate it to anoth sure Line 5001: raise RuntimeError("Bad volume chain found") Line 5002: Line 5003: Line 5004: def _devicesWithAlias(domXML): -- To view, visit https://gerrit.ovirt.org/42921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae354de36db63ae3bf4b4fc7f72df5e306035784 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
