Martin Polednik has posted comments on this change. Change subject: virt: add logic for ppc cpu xml element ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42736/2/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 366: elif feature[0] == '-': Line 367: featureAttrs['policy'] = 'disable' Line 368: cpu.appendChildWithArgs('feature', **featureAttrs) Line 369: elif self.arch in (caps.Architecture.POWER): Line 370: cpu.setAttrs(mode='host-model') > using 'host-model' is a big problem - the CPU exposed to the guest depneds (reason why I'm keeping the patch open and not really working on it) this is being discussed in libvirt and further down the stack. The issue as I understood is the fact that the baseline CPUs are not well defined for ppc64le and host-model is the only option that makes sense. Line 371: Line 372: features = self.conf.get('cpuType', 'power8').split(',') Line 373: model = features[0] Line 374: -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
