Francesco Romani has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/41657/9//COMMIT_MSG Commit Message: Line 6: Line 7: periodic: make VmDispatcher ignore TooManyTasks Line 8: Line 9: VmDispatcher is meant to make N independent operations Line 10: from on (VM bulk sampling), being N the number of active VMs. > from onE* Done Line 11: Line 12: To fullfill this claim, we ignore TooManyTasks in the Line 13: vm dispatching loop, even though is highly likely that Line 14: once one TooManyTasks error is encountered, many subsequent Line 8: Line 9: VmDispatcher is meant to make N independent operations Line 10: from on (VM bulk sampling), being N the number of active VMs. Line 11: Line 12: To fullfill this claim, we ignore TooManyTasks in the > To fulfil this claim, if one of the N independent calls fails with TooManyT Done Line 13: vm dispatching loop, even though is highly likely that Line 14: once one TooManyTasks error is encountered, many subsequent Line 15: dispatch() attempt will fail. Line 16: https://gerrit.ovirt.org/#/c/41657/9/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 245: except Exception: Line 246: # we want to make sure to have VM UUID logged Line 247: self._log.exception("while dispatching %s to VM '%s'", Line 248: self._create, vm_id) Line 249: > I still need the 'else' clause here. Done Line 250: try: Line 251: self._executor.dispatch(op, self._timeout) Line 252: except executor.TooManyTasks: Line 253: skipped.append(vm_id) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
