Martin Polednik has posted comments on this change. Change subject: hostdev: fix hostdev addressing ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43042/3/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: Line 125: def _add_source_address(self, parent_element, address): Line 126: if 'type' not in address: Line 127: address['type'] = CAPABILITY_TO_XML_ATTR[ Line 128: self._deviceParams['capability'] Line 129: ] > this can alter (actually WANTS to alter) the 'address' parameter, which is Good point, but we have to be careful with __init__ - the guest address (self.address) is set up in getUnderlyingHostDeviceInfo and therefore would still lack the type. Any other idea? It could be possible to do via address property, which pretty much handles both issues. -- To view, visit https://gerrit.ovirt.org/43042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d21555ec18d0e8f9766064755443785be3ef697 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
