Dan Kenigsberg has posted comments on this change. Change subject: virt: Forcibly unregister fds with errors from epoll ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/42570/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-07-01 06:36:22 -0400 Line 6: Line 7: virt: Forcibly unregister fds with errors from epoll Line 8: Line 9: To ensure that we do not get spammed with errors, we're now again please point to https://gerrit.ovirt.org/#/c/15393 which dropped unregister, and please state clearly that we do NOT understand how come we still get events from unknown FDs. Line 10: proactively trying to unregister events from epoll Line 11: Line 12: Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf Line 13: Bug-Url: https://bugzilla.redhat.com/1226911 https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 60: # Try to forcibly remove this FD from EPOLL Line 61: # To really stop receiving events Line 62: try: Line 63: self._epoll.unregister(fileno) Line 64: except IOError: > grrrr, I mixed up between epoll.unregister and self.unregister. sorry. We should swallow only ENOENT errors (already unregistered) but log others, right? Line 65: pass Line 66: elif (event & select.EPOLLIN): Line 67: obj = self._channels.get(fileno, None) Line 68: if obj: -- To view, visit https://gerrit.ovirt.org/42570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer%redhat....@gtempaccount.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
