Francesco Romani has posted comments on this change. Change subject: lib: migration: add response helpers ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42795/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 326: destCreationTime) Line 327: Line 328: Line 329: if response.is_failure(result): Line 330: self._last_status = result > introducing a data member so late in the game seems wrong. *Is* wrong :) It is "just" a rebase failure. This patch should build on top of https://gerrit.ovirt.org/#/c/42794/ Line 331: raise RuntimeError('migration destination error: ' + Line 332: result['status']['message']) Line 333: if config.getboolean('vars', 'ssl'): Line 334: transport = 'tls' -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
