Dan Kenigsberg has posted comments on this change.
Change subject: fix crash when sync with libvirt network
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 218:
Line 219: # make directory (if it doesn't exist) and assign it to vdsm
Line 220: if not os.path.exists(dirName):
Line 221: os.makedirs(dirName)
Line 222: os.chown(dirName, vdsm_uid, vdsm_gid)
this function is called by superVdsm, which runs as root.
as far as I recall, the intention behind these chown's was to let vdsm to clear
the backup directory, or even run addNetwork. yet I do not think this is
strictly required these days, and would be glad to get rid of these chowns
after proper mapping of the issue.
I do not understand why uid was not enough, though, and gid is needed, too.
Line 223:
Line 224: open(backup, 'w').write(content)
Line 225: os.chown(backup, vdsm_uid, 0)
Line 226: logging.debug("Persistently backed up %s "
--
To view, visit http://gerrit.ovirt.org/7156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a3ea0303656cba87bf17b14929fe59bf0d46337
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
