Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski <piotr.kliczew...@gmail.com> Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages > Waiting for join() does not prove anything. Do you see the server thread bl Looking in the core dump, we do see two threads - thread 1 is blocked on join(), and the other on queue.get(). But looking in the core - self._enabled seems to be True. We expect it to be False in stop(). #21 Frame 0x7f35af174608, for file /tmp/run/vdsm/vdsm/rpc/bindingxmlrpc.py, line 84, in stop (self=<BindingXMLRPC(_enabled=True, Maybe server_close failed to add the sentinel into the queue? the core does not have enough into to tell that. I think we should learn how to reproduce this, and only then try to fix this. Maybe add more logging and let the ci fail again. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
