Dan Kenigsberg has posted comments on this change. Change subject: Changing sysv to upstart to stop sysv instance and start the upstart one ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/43227/3/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 177 Line 178 Line 179 Line 180 Line 181 this code removal is not really related, and needs to be explained Line 168: Line 169: if os.path.isfile(packaged): Line 170: if hasattr(service, '_chkconfigDisable'): Line 171: service._chkconfigDisable('libvirtd') Line 172: isRan = False libvirtd_was_running_in_sysv is a better name Line 173: if not service._isStopped( Line 174: service._serviceStatus('libvirtd')[1]): Line 175: service._serviceStop('libvirtd') Line 176: isRan = True Line 175: service._serviceStop('libvirtd') Line 176: isRan = True Line 177: if (not os.path.isfile(TARGET) or Line 178: not filecmp.cmp(packaged, TARGET)): Line 179: oldmod = os.stat(TARGET).st_mode TARGET may not exist Line 180: shutil.copyfile(packaged, TARGET) Line 181: if (oldmod is not None and Line 182: oldmod != os.stat(TARGET).st_mode): Line 183: os.chmod(TARGET, oldmod) -- To view, visit https://gerrit.ovirt.org/43227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
