Francesco Romani has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot ......................................................................
Patch Set 4: Code-Review+1 (1 comment) looks OK. please add annotation to schema, see comment inside. https://gerrit.ovirt.org/#/c/43293/4/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 7881: # @snapMemory: #optional str representation of the volumes in which Line 7882: # the memory dump and vm configuration should be saved Line 7883: # Line 7884: # @frozen: #optional Boolean value set to true if the vm is frozen Line 7885: # and does not need to be freezed during the snapshot. please add (new in version 4.17.0) Line 7886: # Line 7887: # Since: 4.10.0 Line 7888: ## Line 7889: {'command': {'class': 'VM', 'name': 'snapshot'}, -- To view, visit https://gerrit.ovirt.org/43293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328470f700ab74daeed5375c0ade83628d16c387 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
