Nir Soffer has posted comments on this change. Change subject: freeze: Cleanup snapshot using freeze() and thaw() ......................................................................
Patch Set 1: (2 comments) Thanks Francesco, I will response.error() usage in the next patch. https://gerrit.ovirt.org/#/c/43298/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3114: try: Line 3115: self._dom.snapshotCreateXML(snapxml, snapFlags) Line 3116: except libvirt.libvirtError: Line 3117: self.log.exception("Unable to take snapshot") Line 3118: return errCode['snapshotErr'] > why not I don't want to mix unrelated changes. Line 3119: finally: Line 3120: # Must always thaw, even if freeze failed; in case the guest Line 3121: # did freeze the filesystems, but failed to reply in time. Line 3122: # Libvirt is using same logic (see src/qemu/qemu_driver.c). Line 3147: Line 3148: # Returning quiesce to notify the manager whether the guest agent Line 3149: # froze and flushed the filesystems or not. Line 3150: return {'status': doneCode, Line 3151: 'quiesce': should_freeze and freezed["status"]["code"] == 0} > we can use I don't want to mix unrelated changes. Line 3152: Line 3153: def diskReplicateStart(self, srcDisk, dstDisk): Line 3154: try: Line 3155: drive = self._findDriveByUUIDs(srcDisk) -- To view, visit https://gerrit.ovirt.org/43298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice74b5619246c979f24909f4ffc3688b3adef6cb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
