Michal Skrivanek has posted comments on this change. Change subject: freeze: Freeze guest even when creating memory snapshot ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/43299/3//COMMIT_MSG Commit Message: Line 10: probably done because qemu is pausing the vm for creating memory Line 11: snapshot. Line 12: Line 13: However, this is not consistent with snapshots of external disks such as Line 14: network disks, where we always freeze the vm before taking the snapshot. > I think we have 2 reason for freezing: per doc quiesce require disk_only. So it should not be used together with memory snapshot Line 15: Also, it is probably safer to freeze even when creating memory snapshot, Line 16: giving applications on the guest chance to pause in consistent state. Line 17: Line 18: This patch removes the check for memory snapshot, and freeze the guest Line 12: Line 13: However, this is not consistent with snapshots of external disks such as Line 14: network disks, where we always freeze the vm before taking the snapshot. Line 15: Also, it is probably safer to freeze even when creating memory snapshot, Line 16: giving applications on the guest chance to pause in consistent state. > AFAICT from libvirt code, it's unneeded. I meant it's unneeded because QEMU itself will provide a consistency. You don't need to quiesce in advance because the qemu emulation will stop for the timebeing of disk snapshot part, so the memory+disk state is in fact consistent and can be continued/resumed. Line 17: Line 18: This patch removes the check for memory snapshot, and freeze the guest Line 19: unless it is already frozen. Line 20: -- To view, visit https://gerrit.ovirt.org/43299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aa7ac0dea8690ca33df8067f84734d788da8bf8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gal Hammer <ghammer%[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
