Adam Litke has posted comments on this change.
Change subject: [WIP]Add text-based console support
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/consoleServer.py
Line 54: finally:
Line 55: servSock.close()
Line 56:
Line 57: self._bitmap[i] = 0x1
Line 58: return i + self._minPort
In that case, why not drop the dependency on this Bitmap and just store the
last used port and round-robin within that port range? It would be simpler and
bind will catch any failures.
Line 59:
Line 60: raise Exception("Can not free port on address: %s", addr)
Line 61:
Line 62: def freePort(self, port):
--
To view, visit http://gerrit.ovirt.org/7165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69904bf7aafd4f764a256d4075c9bf71d988e7c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
