Adam Litke has posted comments on this change. Change subject: Move fencing logic out of API.py ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/API.py Line 1020 Line 1021 Line 1022 Line 1023 Line 1024 Shouldn't the code be more meaningful than always setting it to 1? Eventually we are going to want a formalized set of error codes as part of the schema. It is probably a separate patch, but an issue nonetheless. -- To view, visit http://gerrit.ovirt.org/7190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
