Nir Soffer has posted comments on this change. Change subject: stomp: standalone client ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/42850/4/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 548: Returns JsonRpcClient able to receive jsonrpc messages and notifications. Line 549: It is required to provide host and port where we want to connect and Line 550: request and response queues that we want to use during communication. Line 551: We can provide ssl context if we want to secure connection. Line 552: """ > I think that maybe the best choice instead of this docstring which gives in Please do not log warning for developers, the log is not a place for such stuff, and it keeps customer worried about the behavior of the system. If we have a problem of closing the client when we are done, provide a context manager for this, or better make the sure the client has a start() and stop() method, so we can run it using utils.running: with utils.running(client): use the client ... Line 553: reactor = Reactor() Line 554: thread = threading.Thread(target=reactor.process_requests, Line 555: name='Client %s:%s' % (host, port)) Line 556: thread.setDaemon(True) -- To view, visit https://gerrit.ovirt.org/42850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8af6272679e115cf8eb80a14227476b59812581c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
