Dan Kenigsberg has posted comments on this change.

Change subject: BZ#833425 Change source of CPU sockets/cores to libvirt and add 
cpuThreads.
......................................................................


Patch Set 11:

Amador, frankly, I liked the direct approach. However, using libvirt has its 
benefits: the most important of them is learning what's important to report.

Your patch has merit on its own right, regardless of 
http://gerrit.ovirt.org/#/c/7097/ . I would like to report host cpu topology in 
getVdsCaps - but we should do it properly.

--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to