Mark Wu has posted comments on this change. Change subject: BZ#848299 - Fix delete VLANed network with MTU=9000 ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 561: newmtu = None Line 562: for vlan in vlans: Line 563: if vlan == delvlan: Line 564: continue Line 565: cf = self.NET_CONF_PREF + delvlan My understanding is that it should be changed to delvlan and vlan is right. Line 566: mtu = self._getConfigValue(cf, 'MTU') Line 567: newmtu = max(newmtu, mtu) Line 568: Line 569: if newmtu != currmtu: -- To view, visit http://gerrit.ovirt.org/7214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
