Ido Barkan has posted comments on this change. Change subject: net: wait for restored devices to be up ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/43222/5/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 40: from vdsm.netconfpersistence import RunningConfig, PersistentConfig Line 41: import pkgutil Line 42: Line 43: _NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored') Line 44: _ALL_DEVICES_UP_TIMEOUT = 30 > this is 5 on master! Done Line 45: Line 46: Line 47: def ifcfg_restoration(): Line 48: configWriter = ifcfg.ConfigWriter() Line 176: return changed_or_missing Line 177: Line 178: Line 179: def _wait_for_for_all_devices_up(links): Line 180: timeout = time.time() + _ALL_DEVICES_UP_TIMEOUT > master uses monotonic_time. this is intentional, as stable doesn't have monotonic_time Line 181: down_links = _get_links_with_state_down(links) Line 182: Line 183: # TODO: use netlink monitor here might be more elegant (not available in Line 184: # TODO: 3.5) -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
